Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: The type of the output cloudwatch_log_group_name should be a string and not a list of string #1061

Merged
merged 4 commits into from
Oct 28, 2020
Merged

fix: The type of the output cloudwatch_log_group_name should be a string and not a list of string #1061

merged 4 commits into from
Oct 28, 2020

Conversation

paul-pop
Copy link
Contributor

PR o'clock

Description

Fixes #1060

Checklist

@paul-pop paul-pop changed the title Fix cloudwatch_log_group_name output and change all outputs to be consistent fix: cloudwatch_log_group_name output returns a string Oct 21, 2020
@paul-pop paul-pop mentioned this pull request Oct 21, 2020
Closed
4 tasks
@paul-pop paul-pop changed the title fix: cloudwatch_log_group_name output returns a string fix: cloudwatch_log_group_name output returns type bug Oct 21, 2020
barryib
barryib suggested changes Oct 25, 2020
View reviewed changes
outputs.tf Outdated Show resolved Hide resolved
variables.tf Show resolved Hide resolved
@paul-pop
Copy link
Contributor Author

@barryib happy to merge this?

@barryib barryib mentioned this pull request Oct 28, 2020
Merged
2 tasks
@barryib barryib changed the title fix: cloudwatch_log_group_name output returns type bug fix: The output cloudwatch_log_group_name should be a string and not a list of string Oct 28, 2020
@barryib barryib changed the title fix: The output cloudwatch_log_group_name should be a string and not a list of string fix: The type of the output cloudwatch_log_group_name should be a string and not a list of string Oct 28, 2020
@barryib barryib merged commit ca7593a into terraform-aws-modules:master Oct 28, 2020
@barryib
Copy link
Member

barryib commented Oct 28, 2020

Thanks @paul-pop for your contribution.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@barryib barryib barryib approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cloudwatch_log_group_name output returning incorrect value
2 participants
@paul-pop @barryib