feat: Remove dependency on deprecated hashicorp/template provider
#1297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashicorp/template is deprecated, and the templatefile function should be used instead.
|
This break some use cases. For the record, see hashicorp/terraform#24978 |
|
@dmsalomon Thanks for working on this. Can you please upgrade your branch ? |
dmsalomon
changed the title
|
@barryib Thanks for taking a look at this, I just upgraded the branch. |
barryib
changed the title
barryib
suggested changes
May 5, 2021
barryib
approved these changes
May 17, 2021
barryib
changed the title
hashicorp/template provider
|
Thanks @dmsalomon for your contribution. |
|
This now shipped in v16.0.0 |
barryib
pushed a commit
to barryib/terraform-aws-eks
that referenced
this pull request
May 20, 2021
…erraform-aws-modules#1297) BREAKING CHANGES: We remove the dependency on the deprecated `hashicorp/template` provider and use the Terraform built in `templatefile` function. This will broke some workflows due to previously being able to pass in the raw contents of a template file for processing. The `templatefile` function requires a template file that exists before running a plan.
ArchiFleKs
pushed a commit
to ArchiFleKs/terraform-aws-eks
that referenced
this pull request
Jun 1, 2021
…erraform-aws-modules#1297) BREAKING CHANGES: We remove the dependency on the deprecated `hashicorp/template` provider and use the Terraform built in `templatefile` function. This will broke some workflows due to previously being able to pass in the raw contents of a template file for processing. The `templatefile` function requires a template file that exists before running a plan.
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR o'clock
Description
hashicorp/template is deprecated, and the templatefile function should be used instead. In particular, this is problem on new Apple silicon Macs, since the hashicorp/template provider is not implemented (and I don't ever will be) for darwin_arm64.
Resolves #1294
I have replaced the "template_file" data sources with local variables that store the outputs to function calls using
template. There is actually very little that has changed since the resource arguments map cleanly to the function arguments. I had to use an explicit for loop to render the templates for every node, instead of using thecountmeta-argument.I'm relatively new to Terraform, so all critiques are appreciated.
Checklist