fix: Change instance_metadata_tags to default to null/disabled due to tag key pattern conflict
#1788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…due to tag key pattern conflict
antonbabenko
pushed a commit
that referenced
this pull request
Jan 18, 2022
### [18.2.1](v18.2.0...v18.2.1) (2022-01-18) ### Bug Fixes * Change `instance_metadata_tags` to default to `null`/`disabled` due to tag key pattern conflict ([#1788](#1788)) ([8e4dfa2](8e4dfa2))
|
This PR is included in version 18.2.1 🎉 |
baibailiha
added a commit
to baibailiha/terraform-aws-eks
that referenced
this pull request
Sep 13, 2022
### [18.2.1](terraform-aws-modules/terraform-aws-eks@v18.2.0...v18.2.1) (2022-01-18) ### Bug Fixes * Change `instance_metadata_tags` to default to `null`/`disabled` due to tag key pattern conflict ([#1788](terraform-aws-modules/terraform-aws-eks#1788)) ([54b0c5c](terraform-aws-modules/terraform-aws-eks@54b0c5c))
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
instance_metadata_tagsto default tonull/disableddue to tag key pattern conflictMotivation and Context
disabledwhen a value is not provided. In hindsight, we should have matched the default behavior of the API and let users opt in. I don't know why there is a different tag restriction pattern for metadata tags but its currently causing issues for users so better to opt out and let them opt in as they see fitBreaking Changes
How Has This Been Tested?
examples/*projects