feat: Add autoscaling_group_tags variable to self-managed-node-groups
#2084
Conversation
The cluster-autoscaler discovers ASGs using those tags, which could currently only be set by setting tags on all resources.
gferon
changed the title
|
Thanks for the PR @gferon - lets add an entry in |
Indeed, I forgot to push my last commit. |
gferon
force-pushed
the
auto-scaling-groups-tags
branch
from
f1eb97a
to
34611a4
Compare
| # enable discovery of autoscaling groups by cluster-autoscaler | ||
| autoscaling_group_tags = { | ||
| "k8s.io/cluster-autoscaler/enabled" : true, | ||
| "k8s.io/cluster-autoscaler/${local.name}" : true, |
There was a problem hiding this comment.
per https://docs.aws.amazon.com/eks/latest/userguide/autoscaling.html should this be owned ?
chore: Update variable description to be clear on tag propagation
bryantbiggs
changed the title
autoscaling_group_tags variable to self-managed-node-groups
## [18.23.0](v18.22.0...v18.23.0) (2022-06-02) ### Features * Add `autoscaling_group_tags` variable to self-managed-node-groups ([#2084](#2084)) ([8584dcb](8584dcb))
|
This PR is included in version 18.23.0 🎉 |
…ps (terraform-aws-modules#2084) Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>
## [18.23.0](terraform-aws-modules/terraform-aws-eks@v18.22.0...v18.23.0) (2022-06-02) ### Features * Add `autoscaling_group_tags` variable to self-managed-node-groups ([terraform-aws-modules#2084](terraform-aws-modules#2084)) ([8584dcb](terraform-aws-modules@8584dcb))
## [18.23.0](terraform-aws-modules/terraform-aws-eks@v18.22.0...v18.23.0) (2022-06-02) ### Features * Add `autoscaling_group_tags` variable to self-managed-node-groups ([#2084](terraform-aws-modules/terraform-aws-eks#2084)) ([b80dbf4](terraform-aws-modules/terraform-aws-eks@b80dbf4))
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
cluster-autoscalerdiscovers ASGs using tags, which could currently only be set by setting tags on all resources. This helps setting tags likek8s.io/cluster-autoscaler/enabledon theaws_autoscaling_groupresources only.Motivation and Context
Fixes #2072
Breaking Changes
None
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request