feat: Allow setting custom IRSA policy name for karpenter #2480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickleet
changed the title
patrickleet
changed the title
This was referenced Feb 17, 2023
|
looks like you'll need to run |
fix: run pre-commit run -a
|
@bryantbiggs done |
bryantbiggs
approved these changes
Feb 17, 2023
antonbabenko
pushed a commit
that referenced
this pull request
Feb 17, 2023
## [19.10.0](v19.9.0...v19.10.0) (2023-02-17) ### Features * Allow setting custom IRSA policy name for karpenter ([#2480](#2480)) ([8954ff7](8954ff7))
|
This PR is included in version 19.10.0 🎉 |
|
Thanks @bryantbiggs! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
allow setting custom IRSA policy name separately from custom role name.
You can use
irsa_namecurrently to set them both to the same thing, but there is no way to give them each custom names.Closes #2465
Motivation and Context
My organization has requirements around role and policy names. The module only lets you set a role name currently, and uses that as the policy name. I need to be able to set a policy name, and a role name, and not to the same thing.
Breaking Changes
No. Made it backwards compatible.
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull requestI ran it locally on a project with all combinations of providing names or not.