fix: Add aws_eks_addons.before_compute to the cluster_addons output
#2533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
code-eg
changed the title
|
Looks good and makes sense - is this ready or still waiting for something? |
|
Its ready, I just didn't use the examples projects, I did test on my own personal ones though :) |
bryantbiggs
changed the title
aws_eks_addons.before_compute to the cluster_addons output
antonbabenko
pushed a commit
that referenced
this pull request
Mar 23, 2023
### [19.10.3](v19.10.2...v19.10.3) (2023-03-23) ### Bug Fixes * Add `aws_eks_addons.before_compute` to the `cluster_addons` output ([#2533](#2533)) ([f977d83](f977d83))
|
This PR is included in version 19.10.3 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With the change made in #2478, we are now able to create addons before compute is created, however this doesn't expose new feature as a Terraform output.
Motivation and Context
I have a need to create dependencies on the VPC CNI which I install via before_compute. This would allow me to avoiding any "first run" type behavior and also to ensure cluster resources are cleaned up in the appropriate order.
Breaking Changes
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request