fix: Ensure isra_tag_values can be tried before defaulting to cluster_name on Karpenter module
#2631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuapare
changed the title
joshuapare
changed the title
joshuapare
changed the title
bryantbiggs
changed the title
isra_tag_values can be tried before defaulting to clutser_name on Karpenter module
bryantbiggs
changed the title
isra_tag_values can be tried before defaulting to clutser_name on Karpenter module isra_tag_values can be tried before defaulting to cluster_name on Karpenter module
antonbabenko
pushed a commit
that referenced
this pull request
May 30, 2023
### [19.15.2](v19.15.1...v19.15.2) (2023-05-30) ### Bug Fixes * Ensure `isra_tag_values` can be tried before defaulting to `cluster_name` on Karpenter module ([#2631](#2631)) ([6c56e2a](6c56e2a))
|
This PR is included in version 19.15.2 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
"Coalescelist" uses the first non-empty list. Since var.cluster_name defaults to an empty string, which creates a single-element array with an empty string as the only element (as well as it is almost always specified by the user for other resources such as the queue name and other cluster-named resources in this module) the custom tag values never take affect.
https://developer.hashicorp.com/terraform/language/functions/coalescelist
Motivation and Context
Without this change, passing in the cluster name and specifying custom tag values is not possible. this change is necessary to be able to share resources between clusters. For example, we use the same set of subnets for multiple development clusters with karpenter.sh/discovery/{cluster_name} = "shared" on the subnets for discovery.
Breaking Changes
This does not introduce a breaking change.
How Has This Been Tested?