feat: Add support for allowed_instance_types on self-managed nodegroup ASG
#2757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryantbiggs
changed the title
allowed_instance_types on self-managed nodegroup ASG
antonbabenko
pushed a commit
that referenced
this pull request
Oct 6, 2023
## [19.17.0](v19.16.0...v19.17.0) (2023-10-06) ### Features * Add support for `allowed_instance_types` on self-managed nodegroup ASG ([#2757](#2757)) ([feee18d](feee18d))
|
This PR is included in version 19.17.0 🎉 |
Closed
3 tasks
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As started in #2552, this PR will add the
allowed_instance_typesoption but on the self-managed ASG this time.Motivation and Context
This option could be configured on the Launch Template or the ASG itself but it's easier to see it in AWS Console when it's managed at the ASG level and not buried on the LT (when the situation permits it). It also follow the existing module convention to work with instance attributes scaling.
Breaking Changes
None
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)