-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support additional cluster DNS IPs with Bottlerocket based AMIs #3051
feat: Support additional cluster DNS IPs with Bottlerocket based AMIs #3051
Conversation
I don't know that we will be accepting this change:
bootstrap_extra_args = <<-EOT
[settings.kubernetes]
"cluster-dns-ip" = ["172.21.0.10", "169.254.20.10"]
EOT |
eh, scratch that. we set the IP here in this module. one sec |
yeah its hard-coded to a single ip. Pulling that out completely would also work, users can generate it themselves as an extra arg for the template. |
Sorry, closed by accident |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 👍
## [20.12.0](v20.11.1...v20.12.0) (2024-05-28) ### Features * Support additional cluster DNS IPs with Bottlerocket based AMIs ([#3051](#3051)) ([541dbb2](541dbb2))
This PR is included in version 20.12.0 🎉 |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
Adding support for providing multiple cluster ips into the bottlerocket template.
This resolves #3050
Motivation and Context
Utilities like node local dns may require multiple cluster-dns-ip values to run properly on bottlerocket. Support in bottle rocket has been available since 1.18 https://github.com/bottlerocket-os/bottlerocket/releases/tag/v1.8.0
Breaking Changes
No
How Has This Been Tested?
examples/*
to demonstrate and validate my change(s)examples/*
projectspre-commit run -a
on my pull request