fix: add ip address when manage_aws_auth is true and public_access is false #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-rocket-internet
approved these changes
Mar 11, 2020
|
@slimm609 you have a lint error |
|
fixed |
|
when will this change be released ? |
barryib
suggested changes
Mar 12, 2020
|
changes made |
|
@slimm609 thank you for working on this. Perhaps addressing the merge conflict and squashing the commits will drive this PR forward. |
added 8 commits
March 18, 2020 06:11
slimm609
changed the title
slimm609
changed the title
slimm609
changed the title
max-rocket-internet
approved these changes
Mar 19, 2020
barryib
approved these changes
Mar 19, 2020
4 tasks
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR o'clock
Description
in issue #744, the cluster does not finish configuration when
manage_aws_auth = trueandcluster_endpoint_public_access = falsebecause there is no access to the cluster endpoint.This PR authorizes a CIDR to access the cluster to be able to finish the setup.
Checklist