Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: Use aws_partition to build IAM policy ARNs #820

Merged
merged 2 commits into from
Mar 30, 2020
Merged

improvement: Use aws_partition to build IAM policy ARNs #820

merged 2 commits into from
Mar 30, 2020

Conversation

alloveras
Copy link
Contributor

@alloveras alloveras commented Mar 27, 2020

PR o'clock

Description

Use aws_partition data resource to dynamically build the IAM policy ARNs instead of branching by region name.

Checklist

@alloveras alloveras changed the title Use aws_partition to build IAM policy ARNs improvement: Use aws_partition to build IAM policy ARNs Mar 27, 2020
Copy link
Member

@barryib barryib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh Nice 😍
Thanks for this improvement.

@barryib barryib merged commit 4cc5753 into terraform-aws-modules:master Mar 30, 2020
@alloveras alloveras deleted the alloveras-use-aws-partition branch April 7, 2020 09:02
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants