Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add instance tag specifications to Launch Template #822

Merged
merged 2 commits into from
Mar 30, 2020
Merged

Conversation

Reuuke
Copy link
Contributor

@Reuuke Reuuke commented Mar 30, 2020

PR o'clock

Description

Our company has a policy on the mandatory tags of resources.
If "Tag instances" are not set in the Launch Template, an error occurs:

Error: Error creating AutoScaling Group: AccessDenied: You are not authorized to use launch template: lt-0d9b738051139aab9
	status code: 403, request id: 8db8541f-69d2-4vdc-b4cb-25c920ed342f

  on .terraform/modules/eks/terraform-aws-modules-terraform-aws-eks-ca3d1e1/workers_launch_template.tf line 3, in resource "aws_autoscaling_group" "workers_launch_template":
   3: resource "aws_autoscaling_group" "workers_launch_template" {

The reason is the invocation of "ec2: RunInstances" when the Launch Template is attached to the AutoScaling Group at creation.

Checklist

@Reuuke Reuuke changed the title Add instance tags to Launch template Add instance tags to Launch Template Mar 30, 2020
@Reuuke Reuuke changed the title Add instance tags to Launch Template fix: Add instance tags to Launch Template Mar 30, 2020
@barryib
Copy link
Member

barryib commented Mar 30, 2020

Duplicates #762.

@Reuuke can you please have a look at #762 (comment) and answer the @max-rocket-internet 's question ?

@barryib barryib changed the title fix: Add instance tags to Launch Template feat: Add instance tags to Launch Template Mar 30, 2020
@barryib barryib changed the title feat: Add instance tags to Launch Template feat: Add instance tag specifications to Launch Template Mar 30, 2020
Copy link
Member

@barryib barryib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Reuuke for your contribution.

@barryib barryib merged commit c8195c5 into terraform-aws-modules:master Mar 30, 2020
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants