Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Create kubeconfig with non-executable permissions #864

Merged
merged 3 commits into from
May 6, 2020
Merged

feat: Create kubeconfig with non-executable permissions #864

merged 3 commits into from
May 6, 2020

Conversation

graywolf-at-work
Copy link
Contributor

Kubeconfig does not really need to be executable, so let's not create it with executable bit set.

PR o'clock

Description

Please explain the changes you made here and link to any relevant issues.

Checklist

@graywolf-at-work graywolf-at-work changed the title Create kubeconfig with non-executable permissions bug: Create kubeconfig with non-executable permissions May 6, 2020
Kubeconfig does not really need to be executable, so let's not create it with executable bit set.
@graywolf-at-work graywolf-at-work changed the title bug: Create kubeconfig with non-executable permissions fix: Create kubeconfig with non-executable permissions May 6, 2020
@dpiddockcmp
Copy link
Contributor

Thank you for the PR.

Please bump local's minimum version in versions.tf to 1.4 in order to fix CI.

@barryib barryib changed the title fix: Create kubeconfig with non-executable permissions feat: Create kubeconfig with non-executable permissions May 6, 2020
Copy link
Member

@barryib barryib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@barryib barryib merged commit 312596f into terraform-aws-modules:master May 6, 2020
@barryib
Copy link
Member

barryib commented May 6, 2020

Nice. Thanks @graywolf-at-work for your contribution.

@graywolf-at-work graywolf-at-work deleted the patch-1 branch May 6, 2020 22:37
@barryib barryib mentioned this pull request May 7, 2020
2 tasks
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants