Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update EMR studio service role policy to RequestTags on Create* #5

Merged
merged 1 commit into from
May 18, 2023
Merged

fix: Update EMR studio service role policy to RequestTags on Create* #5

merged 1 commit into from
May 18, 2023

Conversation

terenho-jobber
Copy link
Contributor

fix #4

ResourceTag doesn't work on Create* actions, they need RequestTag

The updates here are inline with service role policy in https://docs.aws.amazon.com/emr/latest/ManagementGuide/emr-studio-service-role.html

bryantbiggs
bryantbiggs approved these changes May 18, 2023
View reviewed changes
Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@bryantbiggs bryantbiggs merged commit 274efc3 into terraform-aws-modules:master May 18, 2023
14 checks passed
@michaelr1980
Copy link

michaelr1980 commented May 18, 2023 •
edited

Yes, thank you @terenho-jobber I also let Anton know incorrectly about this issue; sorry Bryant; either way hope this fix works thanks again for pushing it up terence! :D

@terenho-jobber
Copy link
Contributor Author

Thanks @bryantbiggs.

Do you have any idea when is the next version release and push to https://registry.terraform.io/modules/terraform-aws-modules/emr/aws/latest/submodules/studio? We'd like to consume the fix

@bryantbiggs
Copy link
Member

apologies - it is usually automatic but the release config on main is currently incorrect - hopefully this is corrected after #6

antonbabenko pushed a commit that referenced this pull request May 18, 2023
@semantic-release-bot
chore(release): version 1.1.0 [skip ci]
d987b8d 
## [1.1.0](v1.0.0...v1.1.0) (2023-05-18)

### Features

* Add support for image_configuration block in serverless module ([#2](#2)) ([4d29ee5](4d29ee5))

### Bug Fixes

* Correct auto-release configuration file ([#6](#6)) ([74847b1](74847b1))
* Update EMR studio service role policy to RequestTags on Create* ([#5](#5)) ([274efc3](274efc3))
@antonbabenko
Copy link
Member

This PR is included in version 1.1.0 🎉

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bryantbiggs bryantbiggs bryantbiggs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to start EMR studio workspaces
4 participants
@terenho-jobber @michaelr1980 @bryantbiggs @antonbabenko