Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iam-assumable-roles-with-saml: Allow for multiple provider ids #110

Merged
merged 5 commits into from
Nov 13, 2020
Merged

Conversation

ravanapel
Copy link
Contributor

Description

The aws_iam_policy_document has support for specifying multiple principle federated identifiers like this:

"Principal": {
  "Federated": [
    "arn:aws:iam::012345678912:saml-provider/first",
    "arn:aws:iam::012345678912:saml-provider/second"
  ]
},

Currently, this module only supports specifying one provider_id:

principals {
  type        = "Federated"
  identifiers = [var.provider_id]
}

Motivation and Context

Solves issue #109

Breaking Changes

How Has This Been Tested?

Not yet tested

@ravanapel ravanapel marked this pull request as ready for review November 10, 2020 18:15
@antonbabenko
Copy link
Member

Could you please also update the code in examples for this module?

@ravanapel
Copy link
Contributor Author

Sure! Do you mean expanding the current example with a module that uses multiple provider ids?

@antonbabenko
Copy link
Member

Yes, update the example to show how one and multiple provider ids can be used.

@ravanapel
Copy link
Contributor Author

I've updated the example.

@antonbabenko antonbabenko merged commit 92dbb09 into terraform-aws-modules:master Nov 13, 2020
@antonbabenko
Copy link
Member

v3.4.0 has been just released.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants