Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add arn of created group(s) to outputs #128

Merged
merged 2 commits into from
Jan 29, 2021

Conversation

soupdiver
Copy link
Contributor

@soupdiver soupdiver commented Jan 29, 2021

Description

Export arn of created groups

Motivation and Context

We have multiple AWS accounts across our org. IAM user are kept centrally in one account, are put into groups and the groups get permission to assumeRole in other accounts. We need the group arn for the trustee relationship between the accounts.

How Has This Been Tested?

I run Terraform from my branch and compared the result.

Before:

Unsupported attribute

  on outputs.tf line 5, in output "groups":
   5:       arn   = module.iam-groups[name]. group_arn
    |----------------
    | module.iam-groups is object with 3 attributes

This object does not have an attribute named "group_arn".

After:

Changes to Outputs:
  + groups = [
      + {
          + arn  = (known after apply)
          + name = "data-services-admin"
        },
      + {
          + arn  = (known after apply)
          + name = "data-services-developer"
        },
      + {
          + arn  = (known after apply)
          + name = "zeppelin-admin"
        },
    ]

@soupdiver soupdiver changed the title Update outputs.tf feat: Ad arn of created group(s) to coutputs Jan 29, 2021
@soupdiver soupdiver changed the title feat: Ad arn of created group(s) to coutputs feat: Add arn of created group(s) to coutputs Jan 29, 2021
@soupdiver soupdiver changed the title feat: Add arn of created group(s) to coutputs feat: Add arn of created group(s) to outputs Jan 29, 2021
@antonbabenko antonbabenko merged commit f117007 into terraform-aws-modules:master Jan 29, 2021
@antonbabenko
Copy link
Member

Thanks @soupdiver !

v3.8.0 has been just released.

@github-actions
Copy link

github-actions bot commented Nov 9, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants