Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add role unique_id output in iam-assumable-role module #143

Conversation

carnei-ro
Copy link
Contributor

Description

Adds a new output (iam role unique-id) to module iam-assumable-role

Motivation and Context

We are using HashiCorp Vault version 1.2 and at this version, the only metadata we have to craft policies is the IAM Role Unique ID.

Breaking Changes

None

How Has This Been Tested?

  • I have tested and validated these changes using one or more of the provided examples/* projects

@carnei-ro carnei-ro force-pushed the feat-assumable-role/output-role-unique-id branch from 4717586 to 133a9f5 Compare April 5, 2021 12:29
@carnei-ro carnei-ro force-pushed the feat-assumable-role/output-role-unique-id branch from 133a9f5 to cd9b076 Compare April 5, 2021 12:38
@DrFaust92
Copy link
Contributor

LGTM @antonbabenko

@antonbabenko antonbabenko changed the title feat(assumable-role): Add role unique id output feat: Add role unique_id output in iam-assumable-role module Apr 7, 2021
@antonbabenko antonbabenko merged commit 3c59715 into terraform-aws-modules:master Apr 7, 2021
@antonbabenko
Copy link
Member

v3.14.0 has been just released.

@carnei-ro
Copy link
Contributor Author

Thanks guys!

@github-actions
Copy link

github-actions bot commented Nov 9, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants