Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add iam role unique_id to outputs #149

Merged
merged 4 commits into from
Apr 20, 2021

Conversation

jhancock93
Copy link
Contributor

Description

Adds unique_id from aws_iam_role to outputs.

Motivation and Context

Resolves #141. The unique_id is required in certain AWS contexts, so it is a needed output.

Breaking Changes

No breaking changes.

How Has This Been Tested?

  • I have tested and validated these changes using one or more of the provided examples/* projects
    Deployed module from personal fork and verified that unique_ids are present in the output.

@jhancock93 jhancock93 changed the title Add iam role unique_id to outputs feat: Add iam role unique_id to outputs Apr 19, 2021
@antonbabenko antonbabenko merged commit 5ba3e46 into terraform-aws-modules:master Apr 20, 2021
@antonbabenko
Copy link
Member

Thanks for the addition, @jhancock93 !

Here is AWS IAM documentation about unique ids - https://docs.aws.amazon.com/IAM/latest/UserGuide/reference_identifiers.html#identifiers-unique-ids

v3.16.0 has been just released.

@github-actions
Copy link

github-actions bot commented Nov 9, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose aws_iam_role.unique_id in module outputs
2 participants