Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added id of iam assumable role to outputs #164

Conversation

msharma24
Copy link
Contributor

Description

Added the IAM Instance Profiles ID to the iam-assumanle-role exported output.

Motivation and Context

I was unable to add the IAM instance profiles ID attribute when trying to add iam_instance_profile to an EC2 Terraform Resource using the iam-assumanle-role module.

Breaking Changes

None

How Has This Been Tested?

  • I have tested and validated these changes using one or more of the provided examples/* projects
    Testing
    I add the ID attribute to the outputs and locally tested the module's example template with Terraform version 1.x and provider
    version v.3.58.0
    Terraform apply output showing the IAM Instance Profile ID below:
Outputs:

iam_instance_profile_id = "admin"
iam_role_arn = "arn:aws:iam::185203724531:role/admin"
iam_role_name = "admin"
iam_role_path = "/"
iam_role_unique_id = "AROASWHYASDZ4CRLPZFCH"
role_requires_mfa = true
```

@antonbabenko antonbabenko changed the title Feat/add id attribute iam assumanle role outputs feat: Added id of iam assumable role to outputs Sep 16, 2021
antonbabenko and others added 3 commits September 16, 2021 11:18
…thub.com:msharma24/terraform-aws-iam into feat/add-id-attribute-iam-assumanle-role-outputs
@antonbabenko antonbabenko merged commit 88d01b5 into terraform-aws-modules:master Sep 16, 2021
@antonbabenko
Copy link
Member

Thanks, @msharma24 !

v4.5.0 has been just released.

@msharma24
Copy link
Contributor Author

@antonbabenko Thanks you for the quick review and merge. Cheers !

@github-actions
Copy link

github-actions bot commented Nov 9, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants