fix: Fixed incorrect example of iam-eks-role #183
Conversation
### [4.10.1](v4.10.0...v4.10.1) (2022-01-21) ### Bug Fixes * Fixed incorrect example of iam-eks-role ([#183](#183)) ([c26c44e](c26c44e))
|
This PR is included in version 4.10.1 🎉 |
| length = 2 | ||
| } | ||
|
|
||
| module "eks" { |
There was a problem hiding this comment.
@antonbabenko I don't really see the point of adding a whole declaration of the terraform-aws-eks module in here? Now it's not really clear that you can use this module completely separately. And now the use of (random_pet.this.id) as the cluster name is even more confusing IMO 🙂
There was a problem hiding this comment.
"All examples should ALWAYS be executable right away as-is using terraform apply" - this is the standard rule we have in all modules.
cluster1 was not a known cluster name.
There was a problem hiding this comment.
I think I should have written it differently to be more understandable - (module.eks.cluster_id) instead of (random_pet.this.id).
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Fixes #181