Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Permit RunInstances permission for Karpenter when request contains karpenter.sh/discovery tag key #209

Merged

Conversation

bryantbiggs
Copy link
Member

@bryantbiggs bryantbiggs commented Mar 22, 2022

Description

  • Permit RunInstances permission for Karpenter when request contains karpenter.sh/discovery tag key with cluster ID as the value

Motivation and Context

Breaking Changes

  • No - it currently does not work as written so therefore the changes are not breaking

How Has This Been Tested?

@bryantbiggs bryantbiggs marked this pull request as ready for review March 23, 2022 21:48
@antonbabenko antonbabenko merged commit 18081d1 into terraform-aws-modules:master Mar 23, 2022
antonbabenko pushed a commit that referenced this pull request Mar 23, 2022
### [4.15.1](v4.15.0...v4.15.1) (2022-03-23)

### Bug Fixes

* Permit `RunInstances` permission for Karpenter when request contains `karpenter.sh/discovery` tag key ([#209](#209)) ([18081d1](18081d1))
@antonbabenko
Copy link
Member

This PR is included in version 4.15.1 🎉

@github-actions
Copy link

github-actions bot commented Nov 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants