Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Avoid restricting Karpenter RunInstances subnets by tag key #247

Merged
merged 1 commit into from
May 10, 2022
Merged

fix: Avoid restricting Karpenter RunInstances subnets by tag key #247

merged 1 commit into from
May 10, 2022

Conversation

bryantbiggs
Copy link
Member

Description

  • Avoid restricting Karpenter RunInstances subnets by tag key

Motivation and Context

  • Avoid having to over-tag VPC subnets for multiple Karpenter instances to run in a shared environment; restrictions are already set on launch template and security group

Breaking Changes

  • No; permissions are the same except now a tag is not required on the subnets for Karpenter to function

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@antonbabenko antonbabenko merged commit bbbe0c0 into terraform-aws-modules:master May 10, 2022
antonbabenko pushed a commit that referenced this pull request May 10, 2022
@semantic-release-bot
chore(release): version 4.24.1 [skip ci]
6151579 
### [4.24.1](v4.24.0...v4.24.1) (2022-05-10)

### Bug Fixes

* Avoid restricting Karpenter `RunInstances` subnets by tag key ([#247](#247)) ([bbbe0c0](bbbe0c0))
@antonbabenko
Copy link
Member

This PR is included in version 4.24.1 🎉

@bryantbiggs bryantbiggs deleted the fix/karpenter-subnets branch May 10, 2022 16:55
@bryantbiggs bryantbiggs mentioned this pull request May 10, 2022
Merged
3 tasks
@github-actions
Copy link

github-actions bot commented Nov 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@antonbabenko antonbabenko Awaiting requested review from antonbabenko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bryantbiggs @antonbabenko