Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Trusted Services to iam-assumable-role #31

Merged
merged 1 commit into from
Aug 21, 2019

Conversation

mattmcla
Copy link
Contributor

Adds a new feature that allows for the addition of AWS Service Principals. Specifics on AWS Role Principals can be found here: https://docs.aws.amazon.com/IAM/latest/UserGuide/reference_policies_elements_principal.html

@christophercorn
Copy link

When release is this scheduled for?

@antonbormotov
Copy link

antonbormotov commented Aug 20, 2019

@mattmcla Does it help to achieve following role's policy:

{
  "Version": "2012-10-17",
  "Statement": [
    {
      "Effect": "Allow",
      "Principal": {
        "Service": "ec2.amazonaws.com"
      },
      "Action": "sts:AssumeRole"
    }
  ]
}

?

@mattmcla
Copy link
Contributor Author

@antonbabenko The Policy JSON you provided is the desired output. It's currently not achievable with this module but is a very common AWs pattern. My PR will add that functionality.

@antonbormotov
Copy link

@antonbabenko The Policy JSON you provided is the desired output. It's currently not achievable with this module but is a very common AWs pattern. My PR will add that functionality.

@mattmcla I guess you meant @antonbormotov , not @antonbabenko :)

@antonbabenko, could you, please, facilitate and merge it, as soon as you have spare time.
This is one of the most common policy statements, used in IAM.

@antonbabenko antonbabenko merged commit 40375a5 into terraform-aws-modules:master Aug 21, 2019
@antonbabenko
Copy link
Member

Thanks, Matt and the rest!

This is now merged and v2.2.0 has been released.

@mattmcla
Copy link
Contributor Author

@antonbormotov OH boy haha. Yeah, I sure did, my apologies and thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants