Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update self manage policy to support users with path #335

Merged
merged 4 commits into from
Mar 21, 2023
Merged

fix: Update self manage policy to support users with path #335

merged 4 commits into from
Mar 21, 2023

Conversation

enver
Copy link
Contributor

@enver enver commented Jan 31, 2023

Description

Update self-manage policy to support users with path, regressed in 5.11.0.

Motivation and Context

Changes introduced in #313 removed support for users with path.

Fixes #334

Breaking Changes

None

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@enver enver changed the title Update self manage policy to support users with path fix: Update self manage policy to support users with path Jan 31, 2023
@github-actions
Copy link

github-actions bot commented Mar 3, 2023

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Mar 3, 2023
@enver
Copy link
Contributor Author

enver commented Mar 3, 2023

@antonbabenko Could you please review

@github-actions github-actions bot removed the stale label Mar 4, 2023
@enver enver requested a review from bryantbiggs March 21, 2023 08:04
Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the fix!

@bryantbiggs bryantbiggs merged commit 9a8d5cb into terraform-aws-modules:master Mar 21, 2023
antonbabenko pushed a commit that referenced this pull request Mar 21, 2023
### [5.14.1](v5.14.0...v5.14.1) (2023-03-21)

### Bug Fixes

* Update self manage policy to support users with path ([#335](#335)) ([9a8d5cb](9a8d5cb))
@antonbabenko
Copy link
Member

This PR is included in version 5.14.1 🎉

@enver enver deleted the fix-self-manage-policy-for-users-with-path branch March 21, 2023 11:59
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Self-managed policy in iam-group-with-policies does not work for users with path
3 participants