Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add eks:DescribeCluster for Karpenter cluster endpoint auto discovery #343

Merged
merged 4 commits into from
Mar 8, 2023

Conversation

mikkoc
Copy link
Contributor

@mikkoc mikkoc commented Mar 8, 2023

Description

Add eks:DescribeCluster for Karpenter IRSA role

Motivation and Context

This is needed as of Karpenter 0.25: aws/karpenter-provider-aws#3462

Breaking Changes

No

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects

I tested on my local setup.

  • I have executed pre-commit run -a on my pull request

@mikkoc mikkoc changed the title Add eks:DescribeCluster for Karpenter role feat: Add eks:DescribeCluster for Karpenter role Mar 8, 2023
@bryantbiggs bryantbiggs changed the title feat: Add eks:DescribeCluster for Karpenter role feat: Add eks:DescribeCluster for Karpenter cluster endpoint auto discovery Mar 8, 2023
Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thank you!

@bryantbiggs bryantbiggs merged commit 3f2cdc8 into terraform-aws-modules:master Mar 8, 2023
antonbabenko pushed a commit that referenced this pull request Mar 8, 2023
## [5.12.0](v5.11.2...v5.12.0) (2023-03-08)

### Features

* Add `eks:DescribeCluster` for Karpenter cluster endpoint auto discovery ([#343](#343)) ([3f2cdc8](3f2cdc8))
@antonbabenko
Copy link
Member

This PR is included in version 5.12.0 🎉

@github-actions
Copy link

github-actions bot commented Apr 9, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants