Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for path in iam-group-with-assumable-roles-policy #345

Conversation

lesinigo
Copy link
Contributor

@lesinigo lesinigo commented Mar 9, 2023

Description

Add a new input variable to specify IAM path in iam-group-with-assumable-roles-policy, fixing #344

Motivation and Context

Adds the feature requested in #344 while keeping full backwards compatibility

Breaking Changes

None

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

description = "Path of IAM policy and IAM group"
type = string
default = "/"
validation {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can remove this - its redundant

@bryantbiggs bryantbiggs changed the title feat: Support for non-default IAM paths in iam-group-with-assumable-roles-policy (#344) feat: Add support for path in iam-group-with-assumable-roles-policy Mar 10, 2023
@bryantbiggs bryantbiggs merged commit 761368e into terraform-aws-modules:master Mar 10, 2023
antonbabenko pushed a commit that referenced this pull request Mar 10, 2023
## [5.13.0](v5.12.0...v5.13.0) (2023-03-10)

### Features

* Add support for `path` in `iam-group-with-assumable-roles-policy` ([#345](#345)) ([761368e](761368e))
@antonbabenko
Copy link
Member

This PR is included in version 5.13.0 🎉

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants