Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add kms:decrypt policy for External Secret #349

Merged
merged 4 commits into from
Mar 24, 2023

Conversation

zhuoyang
Copy link
Contributor

@zhuoyang zhuoyang commented Mar 15, 2023

Description

Add kms:decrypt policy for External Secret

Motivation and Context

kms:decrypt policy is needed to get secrets from secret manager.

Reference external-secrets/external-secrets#390

Breaking Changes

N/A

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@zhuoyang zhuoyang changed the title add kms:decrypt policy for External Secret feat: add kms:decrypt policy for External Secret Mar 21, 2023
@zhuoyang zhuoyang changed the title feat: add kms:decrypt policy for External Secret feat: Add kms:decrypt policy for External Secret Mar 21, 2023
@bryantbiggs bryantbiggs changed the title feat: Add kms:decrypt policy for External Secret feat: Add kms:decrypt policy for External Secret Mar 23, 2023
@bryantbiggs bryantbiggs changed the title feat: Add kms:decrypt policy for External Secret fix: Add kms:decrypt policy for External Secret Mar 23, 2023
Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@bryantbiggs bryantbiggs merged commit 2359a03 into terraform-aws-modules:master Mar 24, 2023
antonbabenko pushed a commit that referenced this pull request Mar 24, 2023
### [5.14.4](v5.14.3...v5.14.4) (2023-03-24)

### Bug Fixes

* Add `kms:decrypt` policy for External Secret ([#349](#349)) ([2359a03](2359a03))
@antonbabenko
Copy link
Member

This PR is included in version 5.14.4 🎉

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants