Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add instance profile permissions to Karpenter IRSA policy #434

Merged
merged 6 commits into from
Nov 17, 2023
Merged

feat: Add instance profile permissions to Karpenter IRSA policy #434

merged 6 commits into from
Nov 17, 2023

Conversation

abrabah
Copy link
Contributor

@abrabah abrabah commented Nov 10, 2023

fixes #433

@abrabah
fix: add instance profile permissions to karpenter policy
7a36fec 
fixes #433

Signed-off-by: Abraham Bah <2195667+abrabah@users.noreply.github.com>
@abrabah abrabah changed the title fix: add instance profile permissions to karpenter policy fix: Add instance profile permissions to karpenter policy Nov 10, 2023
@abrabah
fix; use dynamic block instead of repeating StringEquals condition fo…
0fd1b0f 
…r iam:CreateInstanceProfile statement in karpenter policy
abrabah and others added 2 commits November 17, 2023 15:07
@abrabah
fixup! remove unnecessary whitespace
6fb9a8f 
Signed-off-by: Abraham Bah <2195667+abrabah@users.noreply.github.com>
@bryantbiggs
Merge branch 'master' into fix-give-karpenter-oplicy-instance-profile…
d83e117 
…-permissions
@ivankovnatsky
Copy link

Just tested your branch on my side, works as expected! Thanks.

@bryantbiggs bryantbiggs changed the title fix: Add instance profile permissions to karpenter policy feat: Add instance profile permissions to Karpenter IRSA policy Nov 17, 2023
@bryantbiggs bryantbiggs merged commit 50348dd into terraform-aws-modules:master Nov 17, 2023
36 checks passed
antonbabenko pushed a commit that referenced this pull request Nov 17, 2023
@semantic-release-bot
chore(release): version 5.32.0 [skip ci]
91c8dbd 
## [5.32.0](v5.31.0...v5.32.0) (2023-11-17)

### Features

* Add instance profile permissions to Karpenter IRSA policy ([#434](#434)) ([50348dd](50348dd)), closes [#433](#433)
@antonbabenko
Copy link
Member

This PR is included in version 5.32.0 🎉

@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ivankovnatsky ivankovnatsky ivankovnatsky left review comments

@bryantbiggs bryantbiggs bryantbiggs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@abrabah @ivankovnatsky @antonbabenko @bryantbiggs