Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove unused TLS provider in iam-github-oidc-role #439

Conversation

maxbrunet
Copy link
Contributor

Description

As in title

Motivation and Context

This module unnecessarily depends on the tls provider, I believe this copied over from iam-github-oidc-provider

Breaking Changes

N/A

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@maxbrunet maxbrunet changed the title fix(iam-github-oidc-role): remove unused tls provider fix(iam-github-oidc-role): Remove unused tls provider Nov 25, 2023
@bryantbiggs bryantbiggs changed the title fix(iam-github-oidc-role): Remove unused tls provider fix: Remove unused TLS provider in iam-github-oidc-role Dec 11, 2023
@bryantbiggs bryantbiggs merged commit 2ce3885 into terraform-aws-modules:master Dec 11, 2023
36 of 37 checks passed
antonbabenko pushed a commit that referenced this pull request Dec 11, 2023
### [5.32.1](v5.32.0...v5.32.1) (2023-12-11)

### Bug Fixes

* Remove unused TLS provider in `iam-github-oidc-role` ([#439](#439)) ([2ce3885](2ce3885))
@antonbabenko
Copy link
Member

This PR is included in version 5.32.1 🎉

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants