Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for Mountpoint S3 CSI driver to EKS IRSA #459

Merged
merged 12 commits into from
Mar 3, 2024
Merged

feat: Add support for Mountpoint S3 CSI driver to EKS IRSA #459

merged 12 commits into from
Mar 3, 2024

Conversation

josmo
Copy link
Contributor

@josmo josmo commented Feb 13, 2024 •
edited

Description

Adding the required policy for the S3 CSI driver

Motivation and Context

Fixes #456

Breaking Changes

No breaking changes - simply addition for the policy required for the S3 CSI

How Has This Been Tested?

  • I have tested using my branch version with a deployment both with default * buckets and specific bucket arns
  • I have executed pre-commit run -a on my pull request

@josmo josmo changed the title feat: add support for S3 CSI feat: Add support for S3 CSI Feb 13, 2024
@josmo josmo marked this pull request as ready for review February 13, 2024 16:57
bryantbiggs
bryantbiggs requested changes Feb 22, 2024
View reviewed changes
examples/iam-role-for-service-accounts-eks/main.tf Outdated Show resolved Hide resolved
examples/iam-role-for-service-accounts-eks/main.tf Outdated Show resolved Hide resolved
modules/iam-role-for-service-accounts-eks/policies.tf Outdated Show resolved Hide resolved
modules/iam-role-for-service-accounts-eks/policies.tf Outdated Show resolved Hide resolved
modules/iam-role-for-service-accounts-eks/variables.tf Outdated Show resolved Hide resolved
@josmo
fix: update s3_csi refs to mountpoint_s3_csi, example service account…
573c5f0 
… name to match docs, coalescelist with defaults incl partion for defaults to support gov-cloud and other aws partitions, split bucket vs path permissions
@josmo
Copy link
Contributor Author

josmo commented Feb 22, 2024 •
edited

Thanks a ton for the comments @bryantbiggs I think I have everything working and I also did validate with the working config I have before these updates (and temp move blocks for the resources that there were no plan changes) let me know if I need to change anything else.

@bryantbiggs
Copy link
Member

@antonbabenko - FYI, I had to add a hack into the pre-commit workflow since it looks like the Terraform bits are getting big and filling up disk. I wonder if this is related to the AWS SDK Go v1 to v2 migration - https://github.com/terraform-aws-modules/terraform-aws-iam/actions/runs/8126685348/job/22210719103?pr=459

image

@bryantbiggs bryantbiggs changed the title feat: Add support for S3 CSI feat: Add support for Mountpoint S3 CSI driver to EKS IRSA Mar 3, 2024
bryantbiggs
bryantbiggs approved these changes Mar 3, 2024
View reviewed changes
Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@bryantbiggs bryantbiggs merged commit 21fb8d9 into terraform-aws-modules:master Mar 3, 2024
35 checks passed
antonbabenko pushed a commit that referenced this pull request Mar 3, 2024
@semantic-release-bot
chore(release): version 5.36.0 [skip ci]
02d853d 
## [5.36.0](v5.35.0...v5.36.0) (2024-03-03)

### Features

* Add support for Mountpoint S3 CSI driver to EKS IRSA ([#459](#459)) ([21fb8d9](21fb8d9))
@antonbabenko
Copy link
Member

This PR is included in version 5.36.0 🎉

@bryantbiggs bryantbiggs mentioned this pull request Mar 3, 2024
Merged
@antonbabenko
Copy link
Member

antonbabenko commented Mar 3, 2024 •
edited

@antonbabenko - FYI, I had to add a hack into the pre-commit workflow since it looks like the Terraform bits are getting big and filling up disk. I wonder if this is related to the AWS SDK Go v1 to v2 migration - terraform-aws-modules/terraform-aws-iam/actions/runs/8126685348/job/22210719103?pr=459

Thanks for finding the solution to this problem. I thought it was related to many runs of "terraform init", but it is very good to have more space and delete stuff (another way to get more space - k8sgpt-ai/k8sgpt#947 :) ).

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 2, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexey-ban alexey-ban alexey-ban left review comments

@bryantbiggs bryantbiggs bryantbiggs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[iam-role-for-service-accounts-eks] Mountpoint for Amazon S3 CSI driver policy
4 participants
@josmo @bryantbiggs @antonbabenko @alexey-ban