Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow to set force_detach_policies on roles #68

Merged
merged 4 commits into from
Jun 10, 2020
Merged

feat: allow to set force_detach_policies on roles #68

merged 4 commits into from
Jun 10, 2020

Conversation

etwillbefine
Copy link
Contributor

@etwillbefine etwillbefine commented Apr 21, 2020

Description

Allow to set force_detach_policies on IAM roles

Motivation and Context

I have to create a role and attach policies to that. As I use separate, independent modules a change to the role name for example leads to "Cannot delete entity, must delete policies first". In my case there is absolutely no problem by deleting the role. Policies will be attached later again.

Breaking Changes

None, defaults to false (current behaviour)

How Has This Been Tested?

Using my current fork

@etwillbefine etwillbefine changed the title allow to set force_detach_policies on roles feat: allow to set force_detach_policies on roles Apr 21, 2020
Copy link
Contributor

@michelzanini michelzanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antonbabenko antonbabenko merged commit fc56635 into terraform-aws-modules:master Jun 10, 2020
@antonbabenko
Copy link
Member

Thanks @etwillbefine !

v2.11.0 has been just released.

@etwillbefine etwillbefine deleted the force-detach-policies branch June 12, 2020 14:25
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants