Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add support for aliases and grants on aws_kms_external_key #3

Merged

Conversation

ORuessel
Copy link
Contributor

Add to support aliases and permissions for aws_kms_external

Description

In first test it is not possible to add aliases and the permissions to aws_kms_external_key.

Motivation and Context

Breaking Changes

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

upgrade to support aliases and permission for aws_kms_external
@ORuessel ORuessel changed the title Update main.tf - support aws_kms_external_key for aliases and grants fix - support aws_kms_external_key for aliases and grants Aug 12, 2022
@bryantbiggs bryantbiggs changed the title fix - support aws_kms_external_key for aliases and grants fix: Add support for aliases and grants on aws_kms_external_key Aug 12, 2022
main.tf Outdated Show resolved Hide resolved
Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @ORuessel !

@bryantbiggs bryantbiggs merged commit beea8d6 into terraform-aws-modules:master Aug 15, 2022
antonbabenko pushed a commit that referenced this pull request Aug 15, 2022
### [1.0.3](v1.0.2...v1.0.3) (2022-08-15)

### Bug Fixes

* Add support for aliases and grants on `aws_kms_external_key` ([#3](#3)) ([beea8d6](beea8d6))
@antonbabenko
Copy link
Member

This PR is included in version 1.0.3 🎉

@github-actions
Copy link

github-actions bot commented Nov 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants