feat: Added destination_config in aws_lambda_event_source_mapping #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonbabenko
changed the title
|
The reformatting was happening because you use an older version of Terraform (0.13, if I remember correctly). I have fixed the code a bit to make it similar to the rest. |
|
v2.1.0 has been just released. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Uncommenting
destination_configblock within event_source_mapping. Git pre-commit hook performed aterraform fmtresulting in additional formatting changes to unrelated code.How Has This Been Tested?
I'm really not familiar with this module, but I tested it locally by specifying an
event_source_mappingconfig similar to what is inexamples/event-source-mapping. Aplanandapplyworked just fine and i could see that the "On-Failure" destination config was now configured under a dynamoDB trigger for my lambda function. I re-ran aplanagain afterwards just to validate that no other spurious side-effects/changes were detected.