fix: No need to set aws_s3_bucket_object etag as filename is already a hash of the content
#180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdecat
changed the title
aws_s3_bucket_object etag as filename is a already hash of the contentaws_s3_bucket_object etag as filename is already a hash of the content
pdecat
changed the title
aws_s3_bucket_object etag as filename is already a hash of the contentaws_s3_bucket_object etag as filename is already a hash of the content
…t only changes when the actual content changes, while the computed etag was a MD5 hash of the locally built zip archive which always changed
|
Looks good, thank you! v2.11.0 has been just released. PS: Thanks for all other PRs and comments, I am going to reply to those one at a time (ping me if you think one is more urgent than another). |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is no need to set the optional
etagfield of theaws_s3_bucket_objectresource as the filename is a hash of the content that only changes when the actual content changes.Setting
etagto a computed MD5 hash of the locally built zip archive used to always trigger changes.Motivation and Context
When building packages on several workspaces, the MD5 sum of the locally built zip archive always changes.
Setting the
TF_RECREATE_MISSING_LAMBDA_PACKAGEtofalsealone does not resolve that issue.Breaking Changes
N/A
How Has This Been Tested?
examples/*projectsWhen package source content changes, the hash of the zip archive changes, it is properly uploaded to S3, and the Lambda is properly updated to use that version.