Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: one-shot artifacts build #20

Merged

Conversation

ahlinc
Copy link
Contributor

@ahlinc ahlinc commented Jun 10, 2020

Resolves: terraform-aws-modules/terraform-aws-notify-slack#84

Usage:
  > TF_RECREATE_MISSING_LAMBDA_PACKAGE=false terraform apply
It looks like:
  "timestamp" = "<WARNING: Missing lambda zip artifacts wouldn't be restored>"
@ahlinc
Copy link
Contributor Author

ahlinc commented Jun 10, 2020

@antonbabenko Please look to the last commit and if you think that adding a visible warning message into timestamp field is a bad idea then just merge without it.

@antonbabenko
Copy link
Member

LGTM, merging this one.

@antonbabenko antonbabenko merged commit 3951dc9 into terraform-aws-modules:master Jun 10, 2020
@ahlinc ahlinc deleted the feat/one-shot-artifacts-build branch June 11, 2020 11:07
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tried v3.0.0 - unexpected terraform replacement
2 participants