Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added support for self managed kafka in event source mapping #278

Conversation

kty1965
Copy link
Contributor

@kty1965 kty1965 commented Mar 8, 2022

Description

Resolve #277 issue.

Motivation and Context

Breaking Changes

How Has This Been Tested?

  • I have tested and validated these changes using one or more of the provided examples/* projects

need to kafka brokers. you can use AWS MSK.

self_managed_kafka = {
  batch_size = 100
  starting_position = "TRIM_HORIZON"
  topics = [
    "example-topic-v1"
  ]
  self_managed_event_source = [
    {
      endpoints = {
        KAFKA_BOOTSTRAP_SERVERS = "kafka1.example.com:9092,kafka2.example.com:9092"
      }
    }
  ]
  source_access_configuration = [
    {
      type =  "SASL_SCRAM_512_AUTH",
      uri = "SECRET_AUTH_INFO"
    },
    {
      type = "VPC_SUBNET",
      uri = "subnet:subnet-example"
    },
    {
      type = "VPC_SUBNET",
      uri = "subnet:subnet-example"
    },
    {
      type = "VPC_SECURITY_GROUP",
      uri = "security_group:sg-example"
    }
  ]
}

@kty1965 kty1965 changed the title feat: support self managed kafka in event source mapping feat support self managed kafka in event source mapping Mar 8, 2022
@kty1965 kty1965 force-pushed the feat/support-self-managed-kafka branch from cb9cdf6 to 17f9d54 Compare March 8, 2022 02:52
@kty1965 kty1965 changed the title feat support self managed kafka in event source mapping feat: support self managed kafka in event source mapping Mar 8, 2022
@kty1965 kty1965 changed the title feat: support self managed kafka in event source mapping feat: Support self managed kafka in event source mapping Mar 8, 2022
@kty1965 kty1965 force-pushed the feat/support-self-managed-kafka branch from 77fc963 to 94f1c50 Compare March 8, 2022 03:06
@rollue
Copy link

rollue commented Mar 28, 2022

Desperately in need of this PR to be merged

@antonbabenko antonbabenko changed the title feat: Support self managed kafka in event source mapping feat: Added support for self managed kafka in event source mapping Mar 28, 2022
@antonbabenko antonbabenko merged commit ee41186 into terraform-aws-modules:master Mar 28, 2022
antonbabenko pushed a commit that referenced this pull request Mar 28, 2022
## [3.1.0](v3.0.1...v3.1.0) (2022-03-28)

### Features

* Added support for self managed kafka in event source mapping ([#278](#278)) ([ee41186](ee41186))
@antonbabenko
Copy link
Member

This PR is included in version 3.1.0 🎉

@github-actions
Copy link

github-actions bot commented Nov 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support self_managed_kafka event source mapping
3 participants