feat: Add a way to define IAM policy name prefix #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alisson276
changed the title
antonbabenko
approved these changes
Oct 31, 2022
antonbabenko
changed the title
antonbabenko
pushed a commit
that referenced
this pull request
Oct 31, 2022
## [4.4.0](v4.3.0...v4.4.0) (2022-10-31) ### Features * Add a way to define IAM policy name prefix ([#354](#354)) ([7df6bbf](7df6bbf))
|
This PR is included in version 4.4.0 🎉 |
|
We're experiencing an error with version 4.4.0, appears to be caused by this change: |
|
2 mins, I will correct it. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow to give to the policy a name other than the
var.role_nameMotivation and Context
Sometimes we want to import things already created by the AWS Console, and the default policy name is AWSLambdaBasicExecutionRole-<random_uuid>. So in order to be able to import without recreating the policy this change allow to set a new policy name. The default behavior if
var.policy_nameis not set is to use role_name exactly how this was doing before this change.Breaking Changes
I don't think so
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request