Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Properly construct poetry commands when not using docker for building package #420

Merged
merged 1 commit into from
Feb 13, 2023
Merged

fix: Properly construct poetry commands when not using docker for building package #420

merged 1 commit into from
Feb 13, 2023

Conversation

pdecat
Copy link
Contributor

@pdecat pdecat commented Feb 11, 2023

Description

This PR fixes building packages with poetry when not building packages with docker.

Motivation and Context

Resolves #417

Breaking Changes

N/A

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@pdecat pdecat changed the title fix: properly construct poetry commands when not using docker for building package (resolves !417) Properly construct poetry commands when not using docker for building package Feb 11, 2023
@pdecat pdecat mentioned this pull request Feb 11, 2023
Closed
@pdecat pdecat changed the title Properly construct poetry commands when not using docker for building package fix: Properly construct poetry commands when not using docker for building package Feb 11, 2023
aminclip
aminclip reviewed Feb 13, 2023
View reviewed changes
Copy link

@aminclip aminclip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and tested, works as expected.

@antonbabenko antonbabenko merged commit 97b00d3 into terraform-aws-modules:master Feb 13, 2023
antonbabenko pushed a commit that referenced this pull request Feb 13, 2023
@semantic-release-bot
chore(release): version 4.10.1 [skip ci]
1171025 
### [4.10.1](v4.10.0...v4.10.1) (2023-02-13)

### Bug Fixes

* Properly construct poetry commands when not using docker for building package ([#420](#420)) ([97b00d3](97b00d3))
@antonbabenko
Copy link
Member

This PR is included in version 4.10.1 🎉

@pdecat pdecat deleted the fix-poetry-no-docker branch February 13, 2023 14:19
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aminclip aminclip aminclip left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The module should package poetry dependencies
3 participants
@pdecat @antonbabenko @aminclip