Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added support for triggers on docker_registry_image resource #518

Conversation

IlyesDemineExtVeolia
Copy link
Contributor

@IlyesDemineExtVeolia IlyesDemineExtVeolia commented Nov 29, 2023

Description

Fixes #517
Fixes #528

Motivation and Context

Breaking Changes

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@IlyesDemineExtVeolia
Copy link
Contributor Author

@antonbabenko Need review please 🙂

@IlyesDemineExtVeolia IlyesDemineExtVeolia changed the title fix: support trigger docker registry image Bug: support trigger docker registry image Nov 30, 2023
@IlyesDemineExtVeolia IlyesDemineExtVeolia changed the title Bug: support trigger docker registry image Fix: support trigger docker registry image Nov 30, 2023
@IlyesDemineExtVeolia IlyesDemineExtVeolia changed the title Fix: support trigger docker registry image fix: Support trigger docker registry image Nov 30, 2023
@IlyesDemineExtVeolia
Copy link
Contributor Author

Maybe we can create an environment variable to recreate all image docker : TF_RECREATE_DOCKER_IMAGE

@antonbabenko antonbabenko changed the title fix: Support trigger docker registry image feat: Added support for triggers on docker_registry_image resource Jan 12, 2024
@antonbabenko antonbabenko merged commit 4ed7d19 into terraform-aws-modules:master Jan 12, 2024
28 checks passed
antonbabenko pushed a commit that referenced this pull request Jan 12, 2024
## [6.6.0](v6.5.0...v6.6.0) (2024-01-12)

### Features

* Added support for triggers on docker_registry_image resource ([#518](#518)) ([4ed7d19](4ed7d19))
@antonbabenko
Copy link
Member

This PR is included in version 6.6.0 🎉

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants