feat: Added support for alias to have multiple filter criteria same as function #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleboarna
changed the title
aleboarna
changed the title
aleboarna
changed the title
…event source mappings, same as lambda function
aleboarna
force-pushed
the
feat/alias-multiple-filter-criteria
branch
from
4fd5f1f
to
8ebe70f
Compare
|
Hi @pdecat @antonbabenko, Could you please review/approve this PR to fix the alias event mapping issue and align it with existing documentation please ? |
pdecat
reviewed
Jun 18, 2024
Comment on lines
+170
to
+175
| dynamic "filter" { | ||
| for_each = try(flatten([each.value.filter_criteria]), []) | ||
|
|
||
| content { | ||
| pattern = try(filter.value.pattern, null) | ||
| } |
There was a problem hiding this comment.
antonbabenko
changed the title
antonbabenko
approved these changes
Jun 18, 2024
antonbabenko
pushed a commit
that referenced
this pull request
Jun 18, 2024
## [7.7.0](v7.6.0...v7.7.0) (2024-06-18) ### Features * Added support for alias to have multiple filter criteria same as function ([#585](#585)) ([6549ca1](6549ca1))
|
This PR is included in version 7.7.0 🎉 |
|
thank you very much! :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… event source mappings, same as lambda function
Description
I have added support in the alias submodule to have multiple event source mapping
filter_criteriain line with the main lambda function.Motivation and Context
I have wasted an entire evening trying to make event source mapping filter_criteria work on the alias with
operation error Lambda: CreateEventSourceMapping, https response error StatusCode: 400, RequestID: 4d25b930-c830-49e2-bbc7-dbd4add503f7, InvalidParameterValueException: Invalid filter pattern definition.This is based on the example found here
Breaking Changes
Alias will be in line with the existing documentation.
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request