Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for creating lambdas that use Container Images #80

Merged
merged 3 commits into from
Dec 7, 2020
Merged

feat: Add support for creating lambdas that use Container Images #80

merged 3 commits into from
Dec 7, 2020

Conversation

niranjan94
Copy link
Contributor

@niranjan94 niranjan94 commented Dec 2, 2020

Description

Resolves #79

Motivation and Context

Breaking Changes

No breaking changes.

How Has This Been Tested?

  • Tested on a project that uses container image.
  • Tested the example added in this PR
  • Tested Plan & Apply. Works as expected.
     Terraform v0.13.5
     + provider registry.terraform.io/hashicorp/aws v3.19.0
     + provider registry.terraform.io/hashicorp/external v2.0.0
     + provider registry.terraform.io/hashicorp/local v2.0.0
     + provider registry.terraform.io/hashicorp/null v3.0.0
     + provider registry.terraform.io/hashicorp/random v3.0.0
    

@niranjan94 niranjan94 changed the title Add support for creating lambdas that use Container Images feat: Add support for creating lambdas that use Container Images Dec 2, 2020
@antonbabenko
Copy link
Member

Thank you! This one looks pretty good, I will take a deeper look into this during the next couple of days and finish it.

@antonbabenko antonbabenko merged commit 9f9930c into terraform-aws-modules:master Dec 7, 2020
@antonbabenko
Copy link
Member

I have finished this and v1.31.0 has been just released.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for creating Lambdas that use Container Images
2 participants