Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Support for new AWS region #15

Merged
merged 4 commits into from
Nov 15, 2022
Merged

fix: Support for new AWS region #15

merged 4 commits into from
Nov 15, 2022

Conversation

markandersontrocme
Copy link
Contributor

@markandersontrocme markandersontrocme commented Nov 14, 2022

Description

Add support for new AWS region and allow users to not query all regions.

Closes #14

Motivation and Context

data.aws_regions queries all regions and when a new one is added this module breaks until AWS fixes the Terraform provider and aws-sdk-go

Breaking Changes

N/A

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@markandersontrocme markandersontrocme changed the title fix support for new AWS region fix: support for new AWS region Nov 14, 2022
@markandersontrocme markandersontrocme changed the title fix: support for new AWS region fix: Support for new AWS region Nov 14, 2022
@antonbabenko
Copy link
Member

@bryantbiggs Looks like GH Actions does not like directories with dots, or? Failed run - https://github.com/terraform-aws-modules/terraform-aws-pricing/actions/runs/3463780846/jobs/5784485992

@markandersontrocme
Copy link
Contributor Author

markandersontrocme commented Nov 14, 2022

@antonbabenko I found the issue, it's because there's a directory called cost.modules.tf and here it is trying to open it, but it's a directory: https://github.com/clowdhaus/terraform-composite-actions/blob/main/directories/directories.py#L21

@bryantbiggs
Copy link
Member

yes, its what @markandersontrocme has identified - the directory name looks like a file name to pythons glob library

@markandersontrocme
Copy link
Contributor Author

@antonbabenko can we revert this commit (if it's the one that is causing the new GH Actions error): df3ccd8?

and find the fix for the module naming later? This broken module is blocking one of our pipelines...

@antonbabenko
Copy link
Member

Let's merge this (as is) and find the fix in GH actions later.

@antonbabenko antonbabenko merged commit b1d5988 into terraform-aws-modules:master Nov 15, 2022
antonbabenko pushed a commit that referenced this pull request Nov 15, 2022
### [2.0.1](v2.0.0...v2.0.1) (2022-11-15)

### Bug Fixes

* Support for new AWS region ([#15](#15)) ([b1d5988](b1d5988))
@antonbabenko
Copy link
Member

This PR is included in version 2.0.1 🎉

@bryantbiggs
Copy link
Member

this should be fixed in v1.8.3 of the action thanks to @markandersontrocme - clowdhaus/terraform-composite-actions#16

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2022
@antonbabenko
Copy link
Member

This issue has been resolved in version 2.0.2 🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: region not found for name "eu-central-2"
3 participants