Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support enable_http_endpoint - Data API (#59) #117

Merged
merged 2 commits into from
Apr 11, 2020
Merged

feat: Support enable_http_endpoint - Data API (#59) #117

merged 2 commits into from
Apr 11, 2020

Conversation

michaelgmcd
Copy link
Contributor

Description

This PR adds support for the Aurora Serverless Data API added in hashicorp/terraform-provider-aws#11048.

Motivation and Context

Fixes #59

Breaking Changes

No breaking changes. The default is false, the same as it was when this module wasn't specifying it

How Has This Been Tested?

I've tested this in my own Terraform stack.

terraform plan diff:

-/+ resource "aws_rds_cluster" "this" {
...
      ~ enable_http_endpoint                = false -> true
...
}

@michaelgmcd michaelgmcd changed the title feature #59: support enable_http_endpoint (Data API) feat: Support enable_http_endpoint - Data API (#59) Mar 21, 2020
@shmick
Copy link

shmick commented Apr 8, 2020

Hi @antonbabenko would you be able to review this?

@antonbabenko
Copy link
Member

Please update versions.tf to specify the minimum required version of AWS provider. The rest looks good to me.

@shmick
Copy link

shmick commented Apr 9, 2020

@michaelgmcd are you able to update the min AWS version in versions.tf? It would be v2.45

@michaelgmcd
Copy link
Contributor Author

@shmick
Copy link

shmick commented Apr 11, 2020

@antonbabenko looks ok now?

@antonbabenko antonbabenko merged commit 7565ec7 into terraform-aws-modules:master Apr 11, 2020
@antonbabenko
Copy link
Member

Thank you all for this!

v2.17.0 of this module has been just released.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data API
3 participants