Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Tag security group with correct name #380

Merged
merged 1 commit into from
May 12, 2023

Conversation

estahn
Copy link
Contributor

@estahn estahn commented May 12, 2023

Description

The introduction of security_group_name (#376) missed the adjustment of the Name tag for the security group. This rectifies this issue.

Motivation and Context

Consistency and correctness.

Breaking Changes

None.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

The introduction of `security_group_name` missed the adjustment of the `Name` tag for the security group. This rectifies this issue.
@bryantbiggs bryantbiggs merged commit 71d23db into terraform-aws-modules:master May 12, 2023
@estahn estahn deleted the patch-1 branch May 12, 2023 15:05
antonbabenko pushed a commit that referenced this pull request May 12, 2023
### [8.1.1](v8.1.0...v8.1.1) (2023-05-12)

### Bug Fixes

* Tag security group with correct name ([#380](#380)) ([71d23db](71d23db))
@antonbabenko
Copy link
Member

This PR is included in version 8.1.1 🎉

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants