Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Tag Application AutoScaling target #389

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

narqo
Copy link
Contributor

@narqo narqo commented Jun 7, 2023

Description

The changes pass the missing tags to aws_appautoscaling_target.

Motivation and Context

Breaking Changes

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current module version is just ahead of the minimum required provider version https://github.com/hashicorp/terraform-provider-aws/blob/release/4.x/CHANGELOG.md#4661-may--5-2023 - good to go, thank you for the addition!

@bryantbiggs bryantbiggs merged commit 04ffe1c into terraform-aws-modules:master Jun 7, 2023
12 checks passed
@antonbabenko
Copy link
Member

This PR is included in version 8.3.1 🎉

antonbabenko pushed a commit that referenced this pull request Jun 7, 2023
### [8.3.1](v8.3.0...v8.3.1) (2023-06-07)

### Bug Fixes

* Tag Application AutoScaling target ([#389](#389)) ([04ffe1c](04ffe1c))
@github-actions
Copy link

github-actions bot commented Jul 8, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants