Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enable db_parameter_group_name per instance #410

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

galbirk
Copy link
Contributor

@galbirk galbirk commented Oct 9, 2023

Description

Enable to set db_parameter_group_name attribute per replica.

Motivation and Context

Now, we can set db_parameter_group_name just in the whole cluster level. We need the ability to set it per instance.

Breaking Changes

No breaking changes.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@galbirk galbirk changed the title feat: enable db_parameter_group_name per instance feat: Enable db_parameter_group_name per instance Oct 9, 2023
@bryantbiggs bryantbiggs merged commit d34e83c into terraform-aws-modules:master Oct 9, 2023
13 of 14 checks passed
antonbabenko pushed a commit that referenced this pull request Oct 9, 2023
## [8.4.0](v8.3.1...v8.4.0) (2023-10-09)

### Features

* Enable db_parameter_group_name per instance ([#410](#410)) ([d34e83c](d34e83c))
@antonbabenko
Copy link
Member

This PR is included in version 8.4.0 🎉

Copy link

github-actions bot commented Nov 9, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants