Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused submodule output #108

Merged
merged 2 commits into from
Mar 22, 2019

Conversation

dpiddockcmp
Copy link
Contributor

This breaks plan when trying to create a read replica without setting
the master password:

* module.database.module.db_instance.local.this_db_instance_password: local.this_db_instance_password: Resource 'aws_db_instance.this' does not have attribute 'password' for variable 'aws_db_instance.this.*.password'

Less invasive solution for #103 . Although I'm working with MariaDB not Postgres.

Need to set password and username to empty strings. Maybe will be better under TF 0.12 with a null value?

@antonbabenko
Copy link
Member

I think it is a good idea to remove the password from the output, but I am not sure why it makes problems now and not before.

Could you show the code you are trying to get working and add it as a new example to examples directory? I think it is a pretty good idea to show how read-replicas can be created.

This breaks plan when trying to create a read replica without setting
the master password.

module.database.module.db_instance.local.this_db_instance_password: local.this_db_instance_password: Resource 'aws_db_instance.this' does not have attribute 'password' for variable 'aws_db_instance.this.*.password'
@dpiddockcmp
Copy link
Contributor Author

Hi @antonbabenko. I've added simple examples for mysql and postgresql. These fail against master but work with the original changes here.

Copy link
Member

@antonbabenko antonbabenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good and clean!


identifier = "demodb-replica"

# Source database. For cross-region use this_db_instance_arn
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@antonbabenko antonbabenko merged commit af57193 into terraform-aws-modules:master Mar 22, 2019
@antonbabenko
Copy link
Member

Thanks, Daniel!

v1.27.0 has been released.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants