-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused submodule output #108
Conversation
I think it is a good idea to remove the password from the output, but I am not sure why it makes problems now and not before. Could you show the code you are trying to get working and add it as a new example to |
This breaks plan when trying to create a read replica without setting the master password. module.database.module.db_instance.local.this_db_instance_password: local.this_db_instance_password: Resource 'aws_db_instance.this' does not have attribute 'password' for variable 'aws_db_instance.this.*.password'
e741bfa
to
9913375
Compare
Hi @antonbabenko. I've added simple examples for mysql and postgresql. These fail against master but work with the original changes here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good and clean!
|
||
identifier = "demodb-replica" | ||
|
||
# Source database. For cross-region use this_db_instance_arn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Thanks, Daniel! v1.27.0 has been released. |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
This breaks plan when trying to create a read replica without setting
the master password:
* module.database.module.db_instance.local.this_db_instance_password: local.this_db_instance_password: Resource 'aws_db_instance.this' does not have attribute 'password' for variable 'aws_db_instance.this.*.password'
Less invasive solution for #103 . Although I'm working with MariaDB not Postgres.
Need to set password and username to empty strings. Maybe will be better under TF 0.12 with a null value?