Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for issue when MonitoringRoleARN is required #143

Merged
merged 11 commits into from
Jan 7, 2020
Merged

Fix for issue when MonitoringRoleARN is required #143

merged 11 commits into from
Jan 7, 2020

Conversation

flmmartins
Copy link
Contributor

@flmmartins flmmartins commented Jul 9, 2019 •
edited

Description

This fix issue #136 for terraform 0.12

PS: This has not being tested =( since in my infra I still use 0.11. It would be nice if someone could test

@flmmartins flmmartins changed the title terraform012 issue 315 - Fix issue invalidParCombi between mon_role_arn and mon_interval terraform012 #136 - Fix issue invalidParCombi between mon_role_arn and mon_interval Jul 9, 2019
@ozbillwang
Copy link
Contributor

No fix. I still get the error

module.db_instance.aws_db_instance.this[0]: Creating...

Error: Error creating DB Instance: InvalidParameterCombination: A MonitoringRoleARN value is required if you specify a MonitoringInterval value other than 0.
	status code: 400, request id: aeb9b125-e8fb-4290-a4e3-09d79502e5d7

@ozbillwang
Copy link
Contributor

ozbillwang commented Dec 19, 2019 •
edited

ok, seems you didn't set the same as v0.11 (#140 )

This code works with join() function

monitoring_role_arn = var.monitoring_interval > 0 ? coalesce(var.monitoring_role_arn, join(", ", aws_iam_role.enhanced_monitoring.*.arn), null) : null

schulh and others added 9 commits December 19, 2019 13:21
@flmmartins
Copy link
Contributor Author

I updated the code and added the join. @ozbillwang can you review again?

@ozbillwang
Copy link
Contributor

yes, it works with mysql.

I didn't test with mssql. should be fine.

@antonbabenko antonbabenko changed the title terraform012 #136 - Fix issue invalidParCombi between mon_role_arn and mon_interval Fix for issue when MonitoringRoleARN is required Jan 7, 2020
@antonbabenko antonbabenko merged commit 470077e into terraform-aws-modules:master Jan 7, 2020
@antonbabenko
Copy link
Member

Thanks, @flmmartins !

v2.12.0 has been released for Terraform 0.12 users.

@exequielrafaela exequielrafaela mentioned this pull request Mar 31, 2020
Merged
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@flmmartins @ozbillwang @antonbabenko @schulh