Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable performance insights retention period when disabled #153

Merged
merged 1 commit into from
Jul 21, 2019
Merged

Disable performance insights retention period when disabled #153

merged 1 commit into from
Jul 21, 2019

Conversation

walkafwalka
Copy link
Contributor

@walkafwalka walkafwalka commented Jul 19, 2019

Related #147.

Fixes #151.

@walkafwalka walkafwalka changed the title Disable setting performance insights retention period when performance insights is disabled Disable performance insights retention period when performance insights is disabled Jul 19, 2019
@walkafwalka walkafwalka changed the title Disable performance insights retention period when performance insights is disabled Disable performance insights retention period when disabled Jul 19, 2019
@antonbabenko antonbabenko merged commit d3ab45e into terraform-aws-modules:master Jul 21, 2019
@walkafwalka walkafwalka deleted the bug/performance-insights branch July 21, 2019 22:17
flmmartins pushed a commit to flmmartins/terraform-aws-rds that referenced this pull request Dec 19, 2019
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Cannot set PerformanceInsightsRetention without EnablePerformanceInsights
2 participants