Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Added tflint and fixes in README #265

Merged

Conversation

xiaohanxu-nick
Copy link
Contributor

Description

fix some typos in README

Motivation and Context

To make the document more informational and helpful

Breaking Changes

No

How Has This Been Tested?

I have checked the generated README file.

@antonbabenko antonbabenko changed the title fix: READEME typo fix: README typo Oct 15, 2020
@antonbabenko antonbabenko changed the title fix: README typo fix: Added tflint and fixes in README Oct 15, 2020
@antonbabenko antonbabenko merged commit 18e99ee into terraform-aws-modules:master Oct 15, 2020
@antonbabenko
Copy link
Member

Thanks, @Xiaohanxu1996 !

As you can see I added a few other things to your PR.

v2.19.0 has been just released.

@xiaohanxu-nick
Copy link
Contributor Author

Thanks, XD

@aduewel
Copy link

aduewel commented Jun 14, 2021

@antonbabenko @Xiaohanxu1996 why were the aws provider version spec reverted?

@bryantbiggs
Copy link
Member

hi @aduewel - I'm not sure what you mean by provider version spec reverted but this is what the current version specifications are as of today https://github.com/terraform-aws-modules/terraform-aws-rds/blob/master/versions.tf

@aduewel
Copy link

aduewel commented Jun 14, 2021

@bryantbiggs sorry for the confusion ... I overlooked the >= (greater than) ... sorry

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants